Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev/ic



In article <200408131055.32262.abuse%spamalicious.com@localhost>
abuse%spamalicious.com@localhost wrote:

> > > For the c400, set 5380 compatibility mode on every pass through the reset
> > > routine.  The PCMCIA attachment, at least, needs this.
> >
> > This breaks ports !NCR5380_USE_BUS_SPACE.
> 
> So, it turns out that, with the single exception of sun3, all of these ports 
> have bus_space implementations.  Perhaps someone should convert them and 
> remove this conditional from the generic code.

Of course it's better to switch every port to bus_space(9),
but in current code register offsets are hidden by sci_xxx members
so it looks a bit strange to use offset C400_CSR directly in MI code.
I think such MD reset function should be set in MD attachment
and called by a function pointer in softc like sc->sc_intr_on() etc.
---
Izumi Tsutsui
tsutsui%ceres.dti.ne.jp@localhost



Home | Main Index | Thread Index | Old Index