re: CVS commit: src/sys/net

[matthew green <mrg%eterna.com.au@localhost>]

   On Fri, Apr 16, 2004 at 02:08:55PM +1000, matthew green wrote:
   >    
   >    Log Message:
   >    Add a count of the number of packets that match the bpf filter applied 
to a
   >    particule device.  In doing this, make a new the bpf_stat structure with
   >    members that are u_long rather than u_int, matching the counters in the 
bpf_d.
   >    the original bpf_stat is now bpf_stat_old and so to the original ioctl
   >    is preserved as BIOCGSTATSOLD.
   > 
   > 
   > 
   > hmmm.  i don't like this change.  u_int is the same size on 32 bit
   > and 64 bit platforms, thus they don't need any special help to work
   > in netbsd32 compat mode.  u_long, however, isn't.
   > 
   > if you're going to change these structure, PLEASE choose fixed-sized
   > types unless there's a compelling reason not to.
   
   I believe this was resolved in the a commit not long after this after
   I realised what I'd just done...


yes i noticed!  thanks!


.mrg.