Subject: Re: CVS commit: src/sys/sys
To: Christoph Badura <bad@bsd.de>
From: Matthias Scheler <tron@zhadum.de>
List: source-changes
Date: 01/04/2004 01:23:14
On Sun, Jan 04, 2004 at 01:16:31AM +0100, Christoph Badura wrote:
> On Sat, Jan 03, 2004 at 11:29:42PM +0000, Matthias Scheler wrote:
> > Modified Files:
> > 	src/sys/sys: sysctl.h
> > 
> > Log Message:
> > Include "sys/param.h" to fix build problems in applications which include
> > this header file.
> 
> why? sysctl(3) explicitly documents the need to include <sys/param.h> before
> including <sys/sysctl.h>.

Because it is broken by design if a header file doesn't include header
files it requires itself. And because this is a regression. The application
which failed to build because of this can be built without problems
under NetBSD 1.6.2_RC3.

> This should be backed out.

No, it shouldn't.

	Kind regards

-- 
Matthias Scheler                                  http://scheler.de/~matthias/