Subject: re: CVS commit: src/usr.sbin/rtsold
To: Jun-ichiro itojun Hagino <itojun@itojun.org>
From: matthew green <mrg@eterna.com.au>
List: source-changes
Date: 01/03/2004 22:00:49
   > 
   > Jun-ichiro itojun Hagino <itojun@netbsd.org> writes:
   > > Modified Files:
   > > 	src/usr.sbin/rtsold: rtsold.8 rtsold.c
   > >
   > > Log Message:
   > > remove call to pidfile(3), it was just for debugging (and there was no proper
   > > cleanup code).  from kame
   > 
   > Doesn't that prevent the rc scripts from doing things like
   > /etc/rc.d/rtsold restart?
   
   	yup, but rtsold should handle interface removal/insertion well
   	(if not, i should debug it)

and if i WANT to restart it, or stop it?  this is a regression and
should be fixed / backed out.

   
   > Also, pidfile handles cleanup automatically.
   
   	atexit() in NetBSD can be very unsafe at this moment - see
   	http://www.openbsd.org/papers/pacsec03/e/index.html (page 12)
   	so i don't like it be used.

this is absolutely no justification for adding regressions.


.mrg.