Subject: Re: CVS commit: src/usr.sbin/installboot
To: David Laight <dsl@netbsd.org>
From: Valeriy E. Ushakov <uwe@ptc.spbu.ru>
List: source-changes
Date: 11/14/2003 01:01:18
On Thu, Nov 13, 2003 at 08:19:43 +0000, David Laight wrote:

> Module Name:	src
> Committed By:	dsl
> Date:		Thu Nov 13 08:19:43 UTC 2003
> 
> Modified Files:
> 	src/usr.sbin/installboot: Makefile installboot.8 machines.c
> 	src/usr.sbin/installboot/arch: hp300.c
> Removed Files:
> 	src/usr.sbin/installboot: hp300_volhdr.h
> 
> Log Message:
> roundup() write of hp300 boot code to a multiplr of the disk sector size.
> and re-instate the hp300 code - seems to work.

Including sys/disklabel.h in a host tool is a very bad idea, because
even though NetBSD's sys/disklabel.h is used, it, in turn, includes
machine/disklabel.h - which doesn't exist if you cross build on some
other system.

So this breaks the cross build for non-NetBSD hosts.

SY, Uwe
-- 
uwe@ptc.spbu.ru                         |       Zu Grunde kommen
http://www.ptc.spbu.ru/~uwe/            |       Ist zu Grunde gehen