--b8GWCKCLzrXbuNet
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thursday,  9 October 2003 at 23:12:18 -0700, Jason Thorpe wrote:
>
> On Thursday, October 9, 2003, at 08:23  PM, Greg Lehey wrote:
>
>>
>> Module Name:	src
>> Committed By:	grog
>> Date:		Fri Oct 10 03:23:28 UTC 2003
>>
>> Modified Files:
>>	src/sbin/newfs: newfs.c
>>
>> Log Message:
>> Add -V flag for use with Vinum to indicate that the last character of
>> the device name should not be interpreted as a partition identifier.
>
> This clearly hasn't been reviewed sufficiently.

That may be, but I did send it round for review at the end of July.
You may recall a long discussion of vendor branches.  Nobody said
anything about the code, which I took to mean that there were no
objections.

> What's the deal with putting Vinum-specific hacks into generic FFS
> support code?

It's not really Vinum-specific.  It applies to any file system where
the name doesn't include information about partitioning.  But yes, it
*is* a hack.  Arguably, so are partition encodings in the device name.
I'm open to discussion on a better way of doing it.

On Friday, 10 October 2003 at 16:23:31 +1000, matthew green wrote:
>
> what's this all about?  this sounds like a strange option to me
> and i don't recall it being discussed anywhere...
>
> how is it different to using `sysctl kern.rawpartition`?

Good question.  Where do I find the docco for kern.rawpartition?

In any case, the intention here is to stop newfs from looking at the
last letter of the device name and saying "Ah, that must be partition
x.  But we don't have that many partitions".  If there's a nicer way
of doing it, I'm all for it.  In FreeBSD it became superfluous during
the transition to GEOM.

BTW, this applies to fsck as well, and I haven't committed that code
yet.  I'm holding off pending the outcome of this discussion.

Greg
--
See complete headers for address and phone numbers.

--b8GWCKCLzrXbuNet
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.0 (FreeBSD)

iD8DBQE/hlQAIubykFB6QiMRAiaaAJwMS3rGOkJ6RW5T8o6P76U+8ur8+ACdGT+1
fSSpXM1zUYiPxQZQOli+lHE=
=HrpN
-----END PGP SIGNATURE-----

--b8GWCKCLzrXbuNet--