Subject: Re: CVS commit: src
To: None <itojun@netbsd.org>
From: Simon Burge <simonb@wasabisystems.com>
List: source-changes
Date: 09/24/2003 21:18:42
Jun-ichiro itojun Hagino wrote:

> Module Name:	src
> Committed By:	itojun
> Date:		Thu Sep  4 09:17:13 UTC 2003
> 
> Modified Files:
> 
> 	src/distrib/sets/lists/comp: mi
> 	src/sys/netinet: Makefile in_pcb.c in_pcb.h raw_ip.c tcp_input.c
> 	    tcp_subr.c tcp_usrreq.c tcp_var.h udp_usrreq.c
> 	src/sys/netinet6: icmp6.c in6_pcb.c in6_pcb.h in6_proto.c in6_src.c
> 	    raw_ip6.c udp6_usrreq.c udp6_var.h
> Added Files:
> 
> 	src/sys/netinet: in_pcb_hdr.h

@@ -1226,43 +1219,30 @@
 void
 tcp_drain()
 {
+       struct inpcb_hdr *inph;
        struct inpcb *inp;
        struct tcpcb *tp;
 
        /*
         * Free the sequence queue of all TCP connections.
         */
-       inp = CIRCLEQ_FIRST(&tcbtable.inpt_queue);
+       inph = CIRCLEQ_FIRST(&tcbtable.inpt_queue);
        if (inp)                                                /* XXX */

With this change, "inp" is now used unused...  Should
that if () be checking inph instead?

Simon.
--
Simon Burge                            <simonb@wasabisystems.com>
NetBSD Support and Service:         http://www.wasabisystems.com/