Subject: Re: CVS commit: src/sys/miscfs/kernfs
To: None <source-changes@NetBSD.org>
From: Valeriy E. Ushakov <uwe@ptc.spbu.ru>
List: source-changes
Date: 09/10/2003 13:36:48
On Wed, Sep 10, 2003 at 19:33:39 +1000, Daniel Carosone wrote:

> On Wed, Sep 10, 2003 at 05:54:55PM +0900, enami tsugutomo wrote:
> > Daniel Carosone <dan@geek.com.au> writes:
> > 
> > > > Also, attempting to list either of the new ipsecs[ap]/ directories
> > > > results in an instant panic, what looked like "page fault trap in
> > > > supervisor mode" or something similar before the machine rebooted.
> > 
> > NULL pointer deref. introduced in rev. 1.92.  See kernfs_lookup() then
> > you'll find kfs->kfs_kt is NULL for some kind of node.
> 
> It's not in the lookup code.  ls -l makes it panic, plain ls doesn't,
> so it's in getattr. 
> 
> It's not new in 1.92, it's there in 1.91.
> 
> It's only in the ipsecsp dir, I was mistaken. ipsecsa dir is fine.

BTW, in kernfs_gettattr shouldn't the link count for "." be set to 4
only when IPSEC is compiled in and the two additional subdirs are
really present?

SY, Uwe
-- 
uwe@ptc.spbu.ru                         |       Zu Grunde kommen
http://www.ptc.spbu.ru/~uwe/            |       Ist zu Grunde gehen