Subject: Re: CVS commit: src/sys
To: Jason Thorpe <thorpej@wasabisystems.com>
From: Bill Studenmund <wrstuden@netbsd.org>
List: source-changes
Date: 08/25/2003 12:04:40
On Fri, 22 Aug 2003, Jason Thorpe wrote:

>
> On Friday, August 22, 2003, at 02:07  PM, Jonathan Stone wrote:
>
> > And I replied that such a change would need a consensus with Sam
> > Leffer. To do what you want we would also have to change fast-ipsec to
> > accept a struct socket* rather than the struct inpcb* it is passed
> > now.  I also said that we will revisit the inpcb*/inpcb6* issue, after
> > hooks to fit into fast-ipsec existed for review, and both approaches
> > could be compard.
>
> Well, if you knew itojun objected to the change, why did you commit it?
>   What is the point of asking someone to review your changes if you
> simply pretend that they never gave you any feedback?

From what I've seen, Jonathan's not pretending that Itojun didn't give
feedback. He's indicated he wants to defer addressing the point until a
bit later. I expect there have been times when all of us have wanted to do
this in the interest of making progress.

Now whether or not he _should_ wait is a separate issue. ;-)

Take care,

Bill