On Friday, August 22, 2003, at 02:01  PM, Jun-ichiro itojun Hagino 
wrote:

>> In preparation for fast-ipsec.  Reviewed by itojun.
>
> 	no, i objected of passing struct in6pcb * as the argument, i suggested
> 	struct socket * as explicit argument.  why did you commit it ignoring
> 	my comment?  i'll change them to pass struct socket *.

I agree completely with itojun here.  I was privy to the e-mail in 
question (I was CC'd), and itojun clearly objected to the change.

Itojun's suggestion of struct socket * instead is right on the money, 
and the netinet and netinet6 changes to pass the in{,6}pcb should both 
be changed to struct socket *.

If it changes IPv4-specific code in fast-ipsec, so be it.  Part of 
doing system integration is making necessary changes to the integrated 
code.

         -- Jason R. Thorpe <thorpej@wasabisystems.com>