Re: CVS commit: src/sys/kern

[Bill Studenmund <wrstuden%netbsd.org@localhost>]

On Thu, 24 Jul 2003, Jaromir Dolecek wrote:

> Yes, I do plan to fix this properly fairly soon.

Then may I suggest that, unless "fairly soon" is in the next few days (say
this weekend), you put back Christos's "hack", and then revert it when the
proper fix goes in?

While I agree whole-heartedly with your expressed desire to keep the main
code clean, by reverting and not adding a compat-specific fix, we lose
useful functionality.

Take care,

Bill

> Christos Zoulas wrote:
> > In article <20030724073050.25D0FB004%cvs.netbsd.org@localhost>,
> > Jaromir Dolecek <jdolecek%netbsd.org@localhost> wrote:
> > >
> > >Module Name:       src
> > >Committed By:      jdolecek
> > >Date:              Thu Jul 24 07:30:50 UTC 2003
> > >
> > >Modified Files:
> > >   src/sys/kern: uipc_usrreq.c
> > >
> > >Log Message:
> > >back rev 1.63 (the linux hack) off - no compat specific code
> > >in generic code, please
> > >
> > >we need to massage the passed linux cmsg anyway, linux uses different
> > >alignment for CMSG_DATA on at least some architectures
> >
> > The code said specifically why it was there. Unless you are planning
> > to implement CMSG_DATA massaging in compat_linux in the next few
> > weeks, I am putting it back. It is complicated to do the CMSG_DATA
> > massaging, and not needed for the i386, which is where most emulated
> > code runs. I think the ability to run xoveroffice is more important
> > than this tiny hack.
> >
> > I also fail to understand why you proceeded backing this out, when
> > I explicitly replied to your e-mail explaining why it was done.
> >
> > christos
> >
>
> --
> Jaromir Dolecek <jdolecek%NetBSD.org@localhost>            
> http://www.NetBSD.cz/
> -=- We should be mindful of the potential goal, but as the tantric    -=-
> -=- Buddhist masters say, ``You may notice during meditation that you -=-
> -=- sometimes levitate or glow.   Do not let this distract you.''     -=-
>