Re: CVS commit: src/sys

[Jason Thorpe <thorpej%wasabisystems.com@localhost>]

On Sunday, June 29, 2003, at 02:56  AM, Darren Reed wrote:

> Module Name:    src
> Committed By:   darrenr
> Date:           Sun Jun 29 09:56:33 UTC 2003
>
> Modified Files:
>         src/sys/arch/sparc/dev: cgeight.c cgfour.c cgfourteen.c cgtwo.c fd.c
>             kd.c tctrl.c
>         src/sys/arch/sparc/sparc: machdep.c openprom.c vm_machdep.c
>         src/sys/compat/sunos: sunos_exec_aout.c sunos_ioctl.c sunos_misc.c
>         src/sys/dev/ic: z8530tty.c
>         src/sys/dev/sbus: bpp.c magma.c p9100.c tcx.c zx.c
>         src/sys/dev/sun: bwtwo.c cgsix.c cgthree.c event.c event_var.h fb.c
>             fbvar.h kbd.c ms.c
>         src/sys/dev/vme: xd.c xy.c
>         src/sys/fs/adosfs: advfsops.c
>         src/sys/fs/union: union.h union_subr.c union_vfsops.c union_vnops.c

WARNING: There are errors in these changes that can cause a kernel 
crash.  In particular, union_allocvp() obtains the lwp to pass around 
from the cnp argument unconditionally.  However, the cnp argument is 
allowed to be NULL.  It is necessary to add an lwp * argument to 
union_allocvp() and use that instead.

I would suggest that all of these changes need to be audited very 
carefully, as it appears as if simple mechanical changes were made to 
get the code to compile.

        -- Jason R. Thorpe <thorpej%wasabisystems.com@localhost>