Subject: CVS commit: [netbsd-1-6] src/usr.bin/mail
To: None <source-changes@netbsd.org>
From: Matthias Scheler <tron@netbsd.org>
List: source-changes
Date: 06/15/2003 12:52:40
Module Name:	src
Committed By:	tron
Date:		Sun Jun 15 12:52:40 UTC 2003

Modified Files:
	src/usr.bin/mail [netbsd-1-6]: popen.c

Log Message:
Pull up revision 1.15 (requested by perry in ticket #1236):
Fix a bug introduced by Christos Zoulas in version 1.4.
He accidently moved the call to block the SIGCHLD to the wrong side of
the call to findchild().
Caused a coredump in one in every N thousand invocations of mail,
which I have been hunting for literally years.
Fixes PR 19696 from Mason Loring Bliss, too.
By the way, this is a prime example of why declarations of the form
struct foo *p = funcall();
are pure liquid evil.


To generate a diff of this commit:
cvs rdiff -r1.14 -r1.14.2.1 src/usr.bin/mail/popen.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.