Re: CVS commit: src/sys/arch/bebox/stand/boot

[Ben Harris <bjh21%netbsd.org@localhost>]

On Tue, 22 Apr 2003, Bill Studenmund wrote:

> On Sun, 20 Apr 2003, Ben Harris wrote:
>
> >
> > Module Name:        src
> > Committed By:       bjh21
> > Date:               Sun Apr 20 18:17:08 UTC 2003
> >
> > Modified Files:
> >     src/sys/arch/bebox/stand/boot: inkernel.c
> >
> > Log Message:
> > Cast KERNENTRY into a char * before doing arithmetic on it, so we don't end
> > up trying to cast a 64-bit integer into a pointer, which GCC warns about.
>
> It's a nit, but I'd suggest using uint8_t * here. char is not necessarily
> one byte, but uint8_t is.

Erm, is that using a different definition of "byte" from the ANSI C one?
Cos in ANSI C, a byte and a char are defined to be the same size.

In any case, I didn't introduce the char *, I just removed a layer of
parentheses so that NetBSD/bebox could be compiled again.  I'd prefer to
leave any other changes to the maintainer of the code in question.

-- 
Ben Harris                                                   
<bjh21%netbsd.org@localhost>
Portmaster, NetBSD/acorn26           <URL:http://www.netbsd.org/Ports/acorn26/>