Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Subject: pr/5039 CVS commit: src/usr.bin/vacation



On Apr 19, 11:16pm, jhawk%MIT.EDU@localhost (John Hawkinson) wrote:
-- Subject: Re: Subject: pr/5039 CVS commit: src/usr.bin/vacation

I hear you. I added -t A|D to have the user explicitly look at these
fields.

christos

| Umm.
| 
| There needs to be a manpage update...but I'm rather perplexed by this
| change.
| 
| Assuming I am reading this correctly, this change allows vacation to
| reply to messages that come with only an Apparently-To: or a
| Delivered-To: header.
| 
| That's an incredibly bad idea! Delivered-To: (which isn't even a
| standardized header!) often appears to reference the end-user on mail
| to mailing lists. For instance, my mail from source-changes contains
| Delivered-To: jhawk%netbsd.org.@localhost
| 
| Apparently-To: is very weird...it should never properly appear,
| and I think the chances are the mail is not personal mail that
| ought to be replied to in that case. I think the justification for
| adding it is weak. On the other hand, I don't think it's
| actively harmful the way Delivered-To: is.
| 
| Lastly, the comment style appears to be to comment each case statement
| with the full expansion of the header; that should be consistent,
| I think, and also the copyright date should get a bump.
| 
| Please revert this change.
| 
| --jhawk
-- End of excerpt from John Hawkinson





Home | Main Index | Thread Index | Old Index