Re: CVS commit: src/bin/sh

[Jaromir Dolecek <jdolecek%netbsd.org@localhost>]

(taking off source-changes)

Perry E. Metzger wrote:
> Luke Mewburn <lukem%netbsd.org@localhost> writes:
> > Why do I ask for this?  I see it as a matter of courtesy with
> > respect to proper attribution, especially given that I would prefer
> > that I am attributed in this manner in commits made in other projects
> > (i.e, at least as "lukem%netbsd.org@localhost" rather than just "lukem").
> 
> I generally avoid this in order to prevent adding spam to people's
> lives. I usually use full name attributions, i.e. "provided by Joseph
> Smith in PR foo".
> 
> Perhaps if we decide to standardize on email addresses we can use "foo
> at bar.com"? I don't mind the @ for myself -- my email address is in
> so many places it is impossible to avoid -- but others may not
> appreciate it...

I don't think we need to aim for that far reaching 'standard'.
FWIW, I only quote e-mail address if I got the patch/whatever by personal
email (and then use obfuscation), and only if the person is
nondeveloper.  Otherwise I only refer the PR number and/or just
the person's name.

As far as I'm concerned, the attribution could be 'from Joe Smith of
fooBSD' or 'from fooBSD'. The intent here is to keep track where
is origin of the code in the commit message. If you say 'from
jsmith' you suggest this 'jsmith' is from NetBSD, which might not
be correct.

FWIW, if I commit stuff taken from otherBSD, I try to include
revision number from the other CVS tree in the commit message too.
It's really convenient as crossrefernce later.

Jaromir 
-- 
Jaromir Dolecek <jdolecek%NetBSD.org@localhost>            
http://www.NetBSD.org/
-=- We should be mindful of the potential goal, but as the tantric    -=-
-=- Buddhist masters say, ``You may notice during meditation that you -=-
-=- sometimes levitate or glow.   Do not let this distract you.''     -=-