Re: CVS commit: src/sys

[Jaromir Dolecek <jdolecek%netbsd.org@localhost>]

Well, I moved bunch of UNION filesystem specific code to UNION filesystem
specific sources, and added a hook so that the UNION fs can be loaded
via LKM. There is no functionality lost to previous state. It's
up to someone implementeing otherUNION filesystem to make sure the code
is flexible enough to allow that. Adding some generic 'readdir hook'
framework is overkill when you have exactly one consumer. And given
that no other UNION filesystem implementation appeared in last
10 years, I don't think it would appear overnight _now_.

I probably don't understand what you want me to do. What problem
do you have with current code?

Jaromir

Jason R Thorpe wrote:
> On Mon, Mar 17, 2003 at 07:59:55PM +0100, Jaromir Dolecek wrote:
> 
>  > Two different UNION LKMs?
> 
> Hey, why not... you added a hook...
> 
>  > This hook is purely and only for UNION filesystem. The former code
>  > checked (vp->v_op == union_vnodeop_p) for example.  That check was
>  > now moved to union_readdirhook(). The former code was purely UNION
>  > filesystem specific, and so is this vn_union_readdir_hook.
> 
> Then it is screaming for a different way to fix the problem.
> 
> -- 
>         -- Jason R. Thorpe <thorpej%wasabisystems.com@localhost>
> 


-- 
Jaromir Dolecek <jdolecek%NetBSD.org@localhost>            
http://www.NetBSD.org/
-=- We should be mindful of the potential goal, but as the tantric    -=-
-=- Buddhist masters say, ``You may notice during meditation that you -=-
-=- sometimes levitate or glow.   Do not let this distract you.''     -=-