Subject: Re: CVS commit: src/sys/dev
To: Christoph Badura <bad@netbsd.org>
From: Manuel Bouyer <bouyer@antioche.eu.org>
List: source-changes
Date: 01/24/2003 00:00:09
On Thu, Jan 23, 2003 at 02:00:34AM +0200, Christoph Badura wrote:
> 
> Module Name:	src
> Committed By:	bad
> Date:		Thu Jan 23 00:00:34 UTC 2003
> 
> Modified Files:
> 	src/sys/dev/ata: wd.c
> 	src/sys/dev/scsipi: cd.c sd.c
> 
> Log Message:
> Being able to make image backups of your whole disk, not to mention not
> causing certain ata disks to lock up by reading beyond the last block,
> beats catering to broken devices.
> 
> bounds_check_with_label() RAW_PART too.

I'm not sure it's a really good idea. The idea of RAW_PART is that you can
do what you want, including trying to read beyond the end of the raw partition.
If we really want to do this, is should be checked against the size the disk
reported, not what the disklabel says (which may not be accurate).

-- 
Manuel Bouyer <bouyer@antioche.eu.org>
     NetBSD: 24 ans d'experience feront toujours la difference
--