Re: CVS commit: src/sys/dev/qbus

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Wed, Jan 15, 2003 at 03:22:54PM -0800, Matt Thomas wrote:
> At 02:10 PM 1/15/2003, Manuel BOUYER wrote:
> 
> >Module Name:    src
> >Committed By:   bouyer
> >Date:           Wed Jan 15 22:10:26 UTC 2003
> >
> >Modified Files:
> >        src/sys/dev/qbus: if_qe.c
> >
> >Log Message:
> >Zero out the extra space stolen from mbuf to pad packet to ETHER_MIN_LEN
> >XXX should it be ETHER_MIN_LEN - ETHER_CRC_LEN ?
> >XXX2 we assume there are enouth space in the mbuf for the padding bytes.
> >     But other places in the code assumes this already.
> 
> Do not assume you can always write into the mbuf.  See M_READONLY(m) or
> M_TRAILINGSPACE(m)

right, and I misunderstood what the "other places" do.
I have a fix for this (which also gets rid of memset() which is good), but
there is a bug that I need to work out (thanks simh :)

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 23 ans d'experience feront toujours la difference
--