Re: CVS commit: src/sys/dev/pci

[Love <lha%stacken.kth.se@localhost>]

Jason R Thorpe <thorpej%wasabisystems.com@localhost> writes:

> On Sat, Jan 04, 2003 at 01:51:58PM +0900, Izumi Tsutsui wrote:
>
>  > > Modified Files:
>  > >  src/sys/dev/pci: if_vr.c if_vrreg.h
>  > > 
>  > > Log Message:
>  > > From freebsd if_vr.c:1.43,1.56 and if_vrreg.h:1.11,1.14
>  > > 
>  > > - Windows put the chip in suspended mode, make sure we unsuspend
>  > >   it. 1.43, by Takefumi SAYO <stake%po.shiojiri.ne.jp@localhost>
>  > > 
>  > > - Detect the revision of the Rhine chip we're using, and force reset
>  > >   when the chip supports it. 1.65, by silby%freebsd.org@localhost
>  > 
>  > It's better to use common macros in pcireg.h:
>
> Agreed.
>
> FWIW, when I approved Love's patch, many of these vr-local defines
> already existed, so I simply didn't mention it.

Should not the pci_set_powerstate() be use instead of tinkering with the
powerstate register themself. When the power state changes, do you really
need to save parts of the configration state register like vr does ? If you
need, shouldn't pci_set_powerstate() do that too then ?

Love