Re: CVS commit: basesrc/lib/libc/string

[woods%weird.com@localhost (Greg A. Woods)]

[ On Tuesday, November 19, 2002 at 19:51:26 (+0900), Bang Jun-Young wrote: ]
> Subject: Re: CVS commit: basesrc/lib/libc/string
>
> On Tue, Nov 19, 2002 at 11:32:22PM +1300, Dave Sainty wrote:
> > Bang Jun-Young writes:
> > 
> > > 
> > > Module Name:      basesrc
> > > Committed By:     junyoung
> > > Date:             Tue Nov 19 06:53:18 UTC 2002
> > > 
> > > Modified Files:
> > >   basesrc/lib/libc/string: strcasecmp.c
> > > 
> > > Log Message:
> > > Include sys/types.h for u_char.
> > 
> > Wouldn't it be nicer just converting all the "u_char"'s in the file to
> > "unsigned char"?
> 
> Is there any compelling reason to not include sys/types.h here and make
> use of u_char? I did 'make build' after this change, and there was no
> problem.

Why introduce a dependency on a (yet another?) very common header file
just to make some alias for a very standard type?

(personally I think all the 'u_[integer-type]' typedefs are bogus --
just typing out the full word "unsigned" isn't going to suddenly turn us
all into cobol programmers or worse!  on the contrary it may even result
in more readable C code, at least for those not accustomed to this 'u_'
nonsense)

-- 
                                                                Greg A. Woods

+1 416 218-0098;            <g.a.woods%ieee.org@localhost>;           
<woods%robohack.ca@localhost>
Planix, Inc. <woods%planix.com@localhost>; VE3TCP; Secrets of the Weird 
<woods%weird.com@localhost>