Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: basesrc/lib/libc



On Mon, Nov 18, 2002 at 06:35:23AM +0900, itojun%iijlab.net@localhost wrote:

 >      strcpy() might have been safe when the comment is added, but we're not
 >      sure with changes after the addition of comments.  by using strlcpy
 >      we can ensure that the operation is bounded.

Well... I know some of the places that use strcpy() explicitly malloc
the destination buffer of the correct length before the call ... so
in cases like this, use of strlcpy() is completely superfluous.

If the use of strcpy() is safe in a given function, then I don't think
we should replace it with use of a non-standard function like strlcpy().

-- 
        -- Jason R. Thorpe <thorpej%wasabisystems.com@localhost>



Home | Main Index | Thread Index | Old Index