Subject: CVS commit: syssrc/sys/dev/raidframe
To: None <source-changes@netbsd.org>
From: Greg Oster <oster@netbsd.org>
List: source-changes
Date: 11/14/2002 19:11:56
Module Name: syssrc
Committed By: oster
Date: Thu Nov 14 17:11:55 UTC 2002
Modified Files:
syssrc/sys/dev/raidframe: rf_netbsdkintf.c
Log Message:
rf_markalldirty() needs to update the mod_counter for used_spares too!
This bug appears as "incorrect Mod Counters" in 'raidctl -s'. The
reason it was seen only in 'raidctl -s' is because of the conditions
needed to trigger the bug:
a) a raid set is configured
b) no partitions on that set are mounted or are otherwise in-use
c) a component is failed, and subsequently rebuilt to a hot spare
d) the machine is rebooted while something (e.g. 'raidctl -s') has
the device open (and, therefore, rf_markalldirty() has been called)
but before the final rf_update_component_labels() is done.
Needless to say, the window for this happening is *very* small, and it
was only because I was testing some obscure stuff that I even noticed it.
To generate a diff of this commit:
cvs rdiff -r1.145 -r1.146 syssrc/sys/dev/raidframe/rf_netbsdkintf.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.