Re: CVS commit: syssrc/sys/dev/pci

[Bang Jun-Young <junyoung%mogua.com@localhost>]

On Tue, Oct 29, 2002 at 11:27:52AM -0500, Perry E. Metzger wrote:
> 
> Bang Jun-Young <junyoung%mogua.com@localhost> writes:
> > > Can't we remove #ifdef __sparc__ from here? It does not look good at all.
> > 
> > A number of other device drivers have such #if/#endif in them, too. What's
> > wrong with that?
> 
> The general policy is to avoid #ifdefs on architecture unless
> absolutely needed and to handle machine dependencies with machine
> implemented APIs. Other device drivers should *not* have such ifs in
> them if we can at all avoid them.

#ifdef __sparc__ can't easily be avoided in machfb.c, since i386 and 
sparc64 have very different boot process. As you might know, this change
was basically to reduce the number of #ifdef __sparc__ (from 7 to 5).

Jun-Young

-- 
Bang Jun-Young <junyoung%mogua.com@localhost>