Re: CVS commit: basesrc/usr.bin/finger

[Kimmo Suominen <kim%tac.nyc.ny.us@localhost>]

Itojun,

The client is the one running isprint() and isspace(), so it reflects
the settings of the person running the finger client.  If the received
character is printable on his/her screen it should be ok to print it,
regardless of what the remote end thinks it is sending.  I don't see how
this could cause any problems.

There is no standard for non-ASCII finger, so there is no mandate to
strip out the 8th bit.  It is very common to have ISO-8859-1 printable
characters in the plan files of Finnish users.

+ Kim


| From:    itojun%iijlab.net@localhost
| Date:    Sun, 11 Aug 2002 02:29:18 +0900
|
| >>Modified Files:
| >>    basesrc/usr.bin/finger: finger.c net.c
| >>
| >>Log Message:
| >>Obey the locale settings of the user when deciding what characters are
| >>valid for output.  If something bad gets printed, either the locale
| >>settings for the user (or output terminal) are wrong, or the LC_CTYPE
| >>definitions on the system are invalid.
| >     i'm a bit nervous about this change.  it is the remote end (fingerd)
| >     who decides the encoding, not my end (finger).
|
|       and there's no standard for non-ASCII finger.
|
| itojun
|