Subject: Re: CVS commit: syssrc/sys/dev
To: Bang Jun-Young <junyoung@mogua.com>
From: Matthias Drochner <M.Drochner@fz-juelich.de>
List: source-changes
Date: 06/26/2002 12:39:23
junyoung@mogua.com said:
> What I was considering is to add `options ATI_BROKEN_FONTSEL'

I can't find any traces of your patch in my mailbox. Would
you please send it again?

Just to explain things a bit more: Another reason why I made the
number of available font slots variable is to share the font
selection/loading code with the EGA driver in the future.
(might be of limited interest, and I don't even have hardware
to test with, but should be straightforward)

I'm not opposed to an option which enables the "ATI-save"
behavior, it should be present in GENERIC* kernels however.
It could be as simple as
*** vga.c.~1.51.~	Tue Jun 25 23:07:42 2002
--- vga.c	Wed Jun 26 12:25:02 2002
***************
*** 643,649 ****
--- 643,653 ----
  #else
  	scr = vga_console_vc.currenttype;
  #endif
+ #ifdef VGA_CONSOLE_ATI_BROKEN_FONTSEL
  	vga_console_vc.vc_nfontslots = 1; /* for now assume buggy adapter */
+ #else
+ 	vga_console_vc.vc_nfontslots = 8;
+ #endif
  	vga_init_screen(&vga_console_vc, &vga_console_screen, scr, 1, &defattr);
  
  	wsdisplay_cnattach(scr, &vga_console_screen,


What also should be done is to make the default screen type
depending on the console screen type, not hardwired to 80x25.
This requires either making the screen type list in vga.c non-static,
or a change to the wsdisplay interface.

best regards
Matthias