Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: basesrc



On Wed, Jun 19, 2002 at 10:43:28AM +0900, itojun%iijlab.net@localhost wrote:
  | >  | >Log Message:
  | >  | >In afterinstall, only run postinstall check if DESTDIR != / (or 
equivalents).
  | >  | >Fixes [misc/17275] from Gregory McGarry <g.mcgarry%ieee.org@localhost>
  | >  |        is it safe?  i find a lot of upgrade twists/pitfalls with 
postintsall,
  | >  |        when i upgrade machine with DESTDIR=/.  i'd like to see it 
backed out.
  | >  |        (when DESTDIR=/ we will see some warnings, but i know the 
reason why
  | >  |        so i can ignore safe ones)
  | >previously, postinstall check was unconditionally executed.
  | >now, postinstall check is only run for DESTDIR=/ (or equiv).
  | >for the DESTDIR=/ case, nothing has changed for what's been
  | >running for the last few weeks.
  | 
  |     your commit message says the opposite thing to the Makefile, that's
  |     why i'm asking.
  |             commit message - opposite to Makefile
  |             your response - equals to Makefile
  |     i think i'm okay with the Makefile.

excellent call!   no wonder someone else was concerned about this
change as well.

i've fixed the commit message.

(bah, i could blame lack of sleep due to sick baby for my commit msg
sloppiness :)

luke



Home | Main Index | Thread Index | Old Index