Subject: Re: CVS commit: basesrc/lib/libc/arch
To: Thomas Klausner <wiz@netbsd.org>
From: Jason R Thorpe <thorpej@wasabisystems.com>
List: source-changes
Date: 05/26/2002 08:42:17
On Sun, May 26, 2002 at 02:48:05PM +0300, Thomas Klausner wrote:
> Modified Files:
> basesrc/lib/libc/arch/arm: SYS.h
> basesrc/lib/libc/arch/arm/gen: fabs.c
> basesrc/lib/libc/arch/i386: SYS.h
> basesrc/lib/libc/arch/m68k: SYS.h
> basesrc/lib/libc/arch/mips: SYS.h
> basesrc/lib/libc/arch/powerpc: SYS.h
> basesrc/lib/libc/arch/sh3: SYS.h
> basesrc/lib/libc/arch/sh3/gen: fabs.c
> basesrc/lib/libc/arch/sparc: SYS.h
> basesrc/lib/libc/arch/sparc64: SYS.h
> basesrc/lib/libc/arch/vax: SYS.h
> basesrc/lib/libc/arch/x86_64: SYS.h
>
> Log Message:
> __STDC__ is always defined on NetBSD.
Uh, I think you may have just broken ARM. ARM .S files are often
preprocessed with -traditional-cpp.
Please revert this *entire* patch ... and in the future, DO NOT modify
.S files in this way unless you absolutely know for sure there will
not be any unintended side-effects of your change.
--
-- Jason R. Thorpe <thorpej@wasabisystems.com>