Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: basesrc/lib/libc/net



On Wed, Apr 17, 2002 at 08:55:13AM +0900, enami tsugutomo wrote:
> Bill Squier <groo%netbsd.org@localhost> writes:
> 
> > Log Message:
> > botched strn* -> strl*
> > from xs%kittenz.org@localhost
> > 
> > 
> > To generate a diff of this commit:
> > cvs rdiff -r1.45 -r1.46 basesrc/lib/libc/net/rcmd.c
> 
> I guess it is better to use snprintf() instead of str.cpy and str.cat
> and check truncation also (one might want to not use truncated .rhosts
> path).  If truncation really occurs, administrator might want to know
> that (probably something else, program or configuration, is broken).

I agree that we should check truncation as well.  I'll look at it later
tonight.

-- 
Bill Squier (groo%old-ones.com@localhost)                          
http://www.netbsd.org

        I know I don't deserve another chance, but this _is_ America,
        and as an American, aren't I entitled to one?  --Sideshow Bob.



Home | Main Index | Thread Index | Old Index