Re: CVS commit: syssrc/sys/arch/pmax/pmax

[Lennart Augustsson <lennart%augustsson.net@localhost>]

Simon Burge wrote:

> Gregory McGarry wrote:
>
> > Module Name:  syssrc
> > Committed By: gmcgarry
> > Date:         Fri Nov 30 06:40:52 UTC 2001
> >
> > Modified Files:
> >
> >       syssrc/sys/arch/pmax/pmax: machdep.c
> >
> > Log Message:
> >
> > Don't abuse preprocessor flags.
>
> There's a number of places in the kernel where we assume that an
> undefined flag == 0 in preprocessor expressions, some of them to test
> if just one of the tokens is defined.  Is it actaully _abuse_ of the
> preprocessor, or defined(!) behaviour?

Well, in the past it has always been abuse.

    -- Lennart