Re: CVS commit: syssrc/sys/dev/pci

[Lennart Augustsson <lennart%augustsson.net@localhost>]

Chuck Silvers wrote:

> hi,
>
> this driver doesn't compile with the GENERIC config:
>
> ../../../../dev/pci/emuxki.c:391: warning: too many arguments for format
>
> the offending line is:
>
>                 printf(", couldn't establish interrupt", sc->sc_dev.dv_xname);
>
> I'm curious why -Werror didn't catch this for you?
> if you've removed this flag from your local tree,
> you really ought to put it back to help yourself
> avoid checking in code that doesn't compile for others.

Well, I'm not sure what's going on here.  That file compiles without
warning for me too.  Maybe gcc is broken in the new tool chain?
Because this is something that used to produce a warning.

    -- Lennart