Re: CVS commit: basesrc/libexec/telnetd

[Assar Westerlund <assar%netbsd.org@localhost>]

Jun-ichiro itojun Hagino <itojun%netbsd.org@localhost> writes:
> Module Name:  basesrc
> Committed By: itojun
> Date:         Thu Jul 19 04:57:51 UTC 2001
> 
> Modified Files:
>       basesrc/libexec/telnetd: authenc.c ext.h state.c sys_term.c telnetd.c
>           telnetd.h termstat.c utility.c
> 
> Log Message:
> bound-check all "*nfrontp++" code.  from openbsd/heimdal.
> bark if file descriptor goes above FD_SETSIZE.  from openbsd.

output_data:

        ret = vsnprintf(nfrontp, remaining, format, args);
        nfrontp += ret;

shouldn't this be:

        ret = vsnprintf(nfrontp, remaining, format, args);
        nfrontp += min(ret, remaining-1);

?

/assar