On Sun, Mar 25, 2001 at 12:39:22AM +0100, Aymeric Vincent wrote:
> it looks like there is code in our in-tree nvi to support compiling it
> on other operating systems. Removing sys/queue.h from the source is
> likely to break this.

If we're going to support this type of model (support building our
tree on third-party systems), you should move the sources to
src/dist/nvi and use reachover makefiles, like all other third-party
source. I'm not convinced that this should be done however.

The reason I removed the local version of sys/queue.h was because
other sys/* header files were including it instead of
/usr/include/sys/queue.h, and failing because SLIST_* wasn't found
which local changes of mine were using.


> 
> I suggest that we replace the <nvi>/sys/queue.h by our current
> sys/queue.h (although I don't like duplication, I think it's quite
> acceptable here).
> 
> If no one objects, that's what will be done in the version I'm going
> to import soon.
> 
> BTW, could you (all developers) please try to avoid touching vi's
> sources for the next week, until the new version is imported? It was
> boring enough to diff everything, I don't want to go through this
> again for small changes.
> 
> Thanks,
>  Aymeric
> 
> 
> Luke Mewburn <lukem@netbsd.org> writes:
> 
> > Module Name:	basesrc
> > Committed By:	lukem
> > Date:		Mon Mar 19 20:49:21 UTC 2001
> > 
> > Removed Files:
> > 	basesrc/usr.bin/vi/include/sys: queue.h
> > 
> > Log Message:
> > remove local version of sys/queue.h; it doesn't have some of the newer
> > macros (SLIST_* for example), and this breaks compilation of vi when
> > system header files use these newer macros
> > 
> > 
> > To generate a diff of this commit:
> > cvs rdiff -r1.2 -r0 basesrc/usr.bin/vi/include/sys/queue.h
> > 
> > Please note that diffs are not public domain; they are subject to the
> > copyright notices on the relevant files.

-- 
Luke Mewburn  <lukem@wasabisystems.com>  http://www.wasabisystems.com
Luke Mewburn     <lukem@netbsd.org>      http://www.netbsd.org
Wasabi Systems - providing NetBSD sales, support and service.