Subject: Re: CVS commit: syssrc
To: None <p99dreyf@criens.u-psud.fr>
From: Wolfgang Solfrank <ws@tools.de>
List: source-changes
Date: 03/16/2001 15:03:04
Hi,

> > I.e. to page align everything (and while here, to make the code comply to
> > the comment).  
> 
> Well, we already page align everything, don't we?

No.  Of course the actual protection boundaries are page aligned (anything
else wouldn't work).

However, the old code and your new code don't page align the parameter
given by the user (and the old code might pose problems, if vm_daddr
weren't initially page aligned).

From your problem description it seemed to me as though we could cheat
by simply returning the page aligned address of the break value given
by the user (which happens to actually be the _real_ break value, due
to protection boundaries).  That way the userland code wouldn't need to
try to align the break value again.

Additionally your new code still has the problem with comparing the new
break value with vm_daddr, which doesn't correspond to the text in the
comment (which you deleted, supposedly due to it being almost, albeit not
completely, outdated after your change).  Note that I don't have any
first hand knowledge of whether the comment or the actual code was
correct here.

Ciao,
Wolfgang
-- 
ws@TooLs.DE     Wolfgang Solfrank, TooLs GmbH 	+49-228-985800