You're out of date with your source.


On Sat, 24 Feb 2001, Izumi Tsutsui wrote:

> In <Pine.BSF.4.21.0102231737080.38524-100000@beppo.feral.com>
> mjacob@feral.com wrote:
> 
> > Izumi is not correct about bus_dmamap_sync missing.
> 
> Hmm, Ok, I take a look at isp_sbus.c.
> 
> It seems there is no bus_dmamap_sync() with BUS_DMASYNC_PREREAD
> for sbus_result_dmamap. I don't check bus_dmamap_sync()
> implementation of sparc64, but this might cause problem.
> 
> bus_dmamap_sync() with BUS_DMASYNC_POSTWRITE for sbus_rquest_dmamap
> seems also missed, but this would not cause any problem since
> POSTWRITE sync is mostly no-op.
> 
> BTW, isp_sbus.c has some bus_dmamap_sync calls like:
> 
> 	bus_dmamap_sync(sbc->sbus_dmatag, dmap, dmap->dm_segs[0].ds_addr,
> 	    xs->datalen, in? BUS_DMASYNC_PREREAD : BUS_DMASYNC_PREWRITE);
> 
> It looks completely wrong to specify dm_segs[].ds_addr for offset.
> ---
> Izumi Tsutsui
> tsutsui@ceres.dti.ne.jp
>