Subject: Re: CVS commit: basesrc
To: None <itojun@iijlab.net>
From: Luke Mewburn <lukem@wasabisystems.com>
List: source-changes
Date: 01/04/2001 02:40:07
On Thu, Jan 04, 2001 at 12:27:22AM +0900, itojun@iijlab.net wrote:
>
> >Module Name: basesrc
> >Committed By: lukem
> >Date: Wed Jan 3 15:23:27 UTC 2001
> >Modified Files:
> > basesrc/lib/libc/locale: big5.c euc.c euctw.c iso2022.c mskanji.c
> > multibyte.c multibyte_sb.c rune.c runeglue.c runenone.c
> > setlocale_sb.c setrunelocale.c utf2.c utf8.c
> >Log Message:
> >sprinkle in _DIAGASSERT() as appropriate
>
> some of them are purely internal functions (not directly called from
> outside). is _DIAGASSERT() needed in those cases too?
in other places in the tree i'm sure i've added similar code to other
`internal' functions (because it's quite possible that they're called
incorrectly).
whilst it might be argued that this might slow down code, this only
affects people who compile libc with -D_DIAGNOSTIC. i suspect that
there's not many people other than me who actually do this at the
moment :-)