Subject: Re: CVS commit: basesrc
To: None <nisimura@netbsd.org, source-changes@netbsd.org, dave@dtsp.co.nz>
From: Toru Nishimura <nisimura@itc.aist-nara.ac.jp>
List: source-changes
Date: 11/26/2000 15:30:57
> So, for example, this part of this change is incorrect (at least from
> a "quote-correctness" point of view):
>
> -               if ! checkyesno dhclient && [ -z "`hostname`" ]; then
> +               if ! checkyesno dhclient && [ -z `hostname` ]; then
> 
> (The old version was correct, the new version makes assumptions about
> the contects of the output of "hostname", that it doesn't contain
> whitespace.  A pretty safe assumption, but...)

Ok, you're correct in this particular case.  Let me say, it's verbose to
variable assignment like;

	var="`prog`"

I'm skeptical system would pose no problem when hostname(1) returns
white space separated multiple words. 

Tohru Nishimura