Subject: Re: CVS commit: syssrc
To: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
From: None <itojun@iijlab.net>
List: source-changes
Date: 11/11/2000 02:09:25
>> Module Name: syssrc
>> Committed By: itojun
>> Date: Fri Nov 10 11:08:33 UTC 2000
>>
>> Modified Files:
>> syssrc/sys/arch/alpha/tc: scc.c
>>
>> Log Message:
>> /t_line/t_linesw (typo)
>Is this correct?
i was not 100% sure about the change, but without this change the code
will not work.
>This means old code
> if (tp->t_line)
> (*linesw[tp->t_line].l_start)(tp);
>is now changed to
> if (tp->t_linesw)
> (*tp->t_linesw->l_start)(tp);
>but old tp->t_line was initialize to 0 in ttymalloc() and now
>new tp->t_linesw is initialized to linesw[0], which is declared
>in tty_conf.c. (i.e. it is not NULL.)
>I'm not sure about the new line discipline scheme, but
>shouldn't we check if tp->t_linesw is equal with linesw[0] or not?
i'm not sure why the old behavior does not call l_start if
tp->t_line == 0 (meaning "termios" line discipline). why we don't
call l_start for termios case? i'm also not a guru here.
itojun