Subject: Re: CVS commit: syssrc
To: None <itojun@netbsd.org>
From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
List: source-changes
Date: 11/11/2000 01:27:24
In <200011101108.NAA27915@netbsd.hut.fi>
itojun@netbsd.org wrote:

> Module Name:	syssrc
> Committed By:	itojun
> Date:		Fri Nov 10 11:08:33 UTC 2000
> 
> Modified Files:
> 	syssrc/sys/arch/alpha/tc: scc.c
> 
> Log Message:
> /t_line/t_linesw (typo)

Is this correct? This means old code

		if (tp->t_line)
			(*linesw[tp->t_line].l_start)(tp);

is now changed to

		if (tp->t_linesw)
			(*tp->t_linesw->l_start)(tp);

but old tp->t_line was initialize to 0 in ttymalloc() and now
new tp->t_linesw is initialized to linesw[0], which is declared
in tty_conf.c. (i.e. it is not NULL.)

I'm not sure about the new line discipline scheme, but
shouldn't we check if tp->t_linesw is equal with linesw[0] or not?
---
Izumi Tsutsui
tsutsui@ceres.dti.ne.jp