Subject: Re: CVS commit: syssrc
To: None <enami@sm.sony.co.jp>
From: ITOH Yasufumi <itohy@netbsd.org>
List: source-changes
Date: 11/02/2000 21:01:49
In article <tkrpukey5xn.fsf@parity-error.sm.sony.co.jp>
enami@sm.sony.co.jp writes:
> ITOH Yasufumi <itohy@netbsd.org> writes:
>
> > Modified Files:
> > syssrc/sys/compat/common: tty_43.c
> > syssrc/sys/net: if_sl.c if_strip.c
>
> We need to reset to the default line discipline instead of setting to
> NULL. What happen someone open a tty after slattach exits.
>
> IMHO, leaving t_linesw as NULL just makes code complex.
Fixed as suggested. Thanks.
> And, it is better to test t_linesw directly against each &xxxx_disc
> instead of testing l_no, isn't it?
Agreed.
However, some other portions seem to allow t_linesw to be zero....
If t_linesw will never be zero, the check of other places aren't
needed, either.
What is the intention of the tty change?
--
ITOH, Yasufumi