On Thu, 2 Nov 2000, Jun-ichiro itojun Hagino wrote:
> >> 	pkgsrc/devel/bison: Makefile
> >> Log Message:
> >> update dependency to gettext.  BUILD_DEPEND on gettext, and have USE_LIBINTL.
> >I think you should add a USE_GETTEXT while you're visiting all the places
> >that might need it. We'll have to only change code in bsd.pkg.mk when
> >citrus gets merged in (assuming it comes with a gettext).
> 
> 	we are waiting for BSD-licensed gettext(1) and msgfmt(1) from Todd.
> 	(i planned to bring in GNU gettext userland tools, but Todd said that
> 	he has compatible one, we are waiting for it)

sure, but when we get it, we'll go through all Makefiles again.
My idea was to make the two related changes at once, then change the code
in bsd.pkg.pk to switch from the gettext pkg to in-tree gettext...


> 	I thought about having USE_GETTEXT but it seems unnecessary to me
> 	now.
> 
> 	the above change converts the following line:
> 		DEPENDS+=	gettext->=x.x.xx:../../devel/gettext
> 	into
> 		BUILD_DEPENDS+=	msgfmt:../../gettext
> 		USE_LIBINTL=yes
> 	the newer one should work just fine even if we see msgfmt(1) from Todd,
> 	assuming that Todd's implementation provides enough compatibility
> 	with GNU gettext.  please give your comments.
> 
> 	btw, we can not do the above change automagically, as some of the
> 	pkgsrc Makefile require msgfmt and some of them does not.  also it
> 	should be noted that the older one (one-line DEPENDS) should still
> 	work fine.  the problem we are seeing now (as Bernd reported) is that
> 	we had some *_DEPENDS line lacking in some of pkgsrc.

Right, and while we have to go through it, we could mark both requirements
at once, see above.


 - Hubert

-- 
Hubert Feyrer <hubert@feyrer.de>