[ On Tuesday, June 27, 2000 at 13:35:13 (+0200), Hubert Feyrer wrote: ]
> Subject: Re: CVS commit: syssrc
>
> On 27 Jun 2000, Klaus Klein wrote:
> > > > Modified Files:
> > > > 	syssrc/sys/sys: mman.h
> > > > 
> > > > Log Message:
> > > > Provide local definitions of mode_t and off_t, thus eliminating the need
> > > > for an application to include <sys/types.h> first.
> > > Why not just pull in <sys/types.h> ?
> > I think you already provided the answer for this one.
> 
> I meant, why not pull in <sys/types.h> in <sys/mman.h>?

Indeed.

I really really really do not like to see multiple definitions of types
in separate user-visible headers, *even* if they are protected from
multiple declarations.  Such practices are just asking for trouble --
things will eventually break and the complication is simply not necessary.

Either include <sys/types.h> within <sys/mman.h>, *or* leave well enough
alone and let application programmers RTFM and include <sys/types.h>
themselves just as the manual page instructs them to do.

(I would slightly prefer that <sys/mman.h> automatically include
<sys/types.h> since that is what Solaris (SunOS-5.6) does.)

-- 
							Greg A. Woods

+1 416 218-0098      VE3TCP      <gwoods@acm.org>      <robohack!woods>
Planix, Inc. <woods@planix.com>; Secrets of the Weird <woods@weird.com>