Re: CVS commit: basesrc

[christos%zoulas.com@localhost (Christos Zoulas)]

In article <12016.955501776%eterna.com.au@localhost>,
matthew green <mrg%eterna.com.au@localhost> wrote:
> 
>    Christos Zoulas wrote:
>    > It is better and more portable to cast it to unsigned char; in this
>    > case it does not make a difference (because there is a check that
>    > the char is > 0, but in general it is better practice.
>    
>    I'll change the definition to unsigned char instead.
> 
> 
> be wary of doing this -- unsigned char propogation is a *nightmare*
> when it comes to writing code that does not generate warnings!

promoting a char to an int is inherently less portable than promoting
a char to an unsigned char.

christos