Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sbin/mount pathadj() is required to succeed. If it cannot,...



details:   https://anonhg.NetBSD.org/src/rev/356379832a7f
branches:  trunk
changeset: 376004:356379832a7f
user:      kre <kre%NetBSD.org@localhost>
date:      Thu May 25 17:37:05 2023 +0000

description:
pathadj() is required to succeed.   If it cannot, simply issuing a
warning and continuing is not good enough.  Change the warning to
an error (and hence immediate exit) instead, that's all we can do.

Problem pointed out by tlaronde%polynum.com@localhost

XXX - pullup -10 (others?)

diffstat:

 sbin/mount/pathadj.c |  8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)

diffs (22 lines):

diff -r 81c4dabd77ff -r 356379832a7f sbin/mount/pathadj.c
--- a/sbin/mount/pathadj.c      Thu May 25 17:24:17 2023 +0000
+++ b/sbin/mount/pathadj.c      Thu May 25 17:37:05 2023 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: pathadj.c,v 1.3 2020/07/26 08:20:22 mlelstv Exp $      */
+/*     $NetBSD: pathadj.c,v 1.4 2023/05/25 17:37:05 kre Exp $  */
 
 /*
  * Copyright (c) 2008 The NetBSD Foundation.  All Rights Reserved.
@@ -37,10 +37,8 @@ void
 pathadj(const char *input, char *adjusted)
 {
 
-       if (realpath(input, adjusted) == NULL) {
-               warn("Warning: realpath %s", input);
-               return;
-       }
+       if (realpath(input, adjusted) == NULL)
+               err(EXIT_FAILURE, "realpath '%s' failed", input);
 
        if (input[0] != '/') {
                warnx("\"%s\" is a relative path.", input);



Home | Main Index | Thread Index | Old Index