[src/trunk]: src/lib/libc/locale Fix parsing a locale string with multiple co...

[mlelstv <mlelstv%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/0002e877d198
branches:  trunk
changeset: 374280:0002e877d198
user:      mlelstv <mlelstv%NetBSD.org@localhost>
date:      Sun Apr 16 20:37:59 2023 +0000

description:
Fix parsing a locale string with multiple components.
Also check for truncation of a long locale string.

diffstat:

 lib/libc/locale/newlocale.c |  11 ++++++++---
 1 files changed, 8 insertions(+), 3 deletions(-)

diffs (46 lines):

diff -r d6f27f7f8638 -r 0002e877d198 lib/libc/locale/newlocale.c
--- a/lib/libc/locale/newlocale.c       Sun Apr 16 19:26:20 2023 +0000
+++ b/lib/libc/locale/newlocale.c       Sun Apr 16 20:37:59 2023 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: newlocale.c,v 1.3 2013/09/13 13:13:32 joerg Exp $ */
+/* $NetBSD: newlocale.c,v 1.4 2023/04/16 20:37:59 mlelstv Exp $ */
 
 /*-
  * Copyright (c)2008, 2011 Citrus Project,
@@ -27,7 +27,7 @@
  */
 
 #include <sys/cdefs.h>
-__RCSID("$NetBSD: newlocale.c,v 1.3 2013/09/13 13:13:32 joerg Exp $");
+__RCSID("$NetBSD: newlocale.c,v 1.4 2023/04/16 20:37:59 mlelstv Exp $");
 
 #include "namespace.h"
 #include <assert.h>
@@ -57,7 +57,10 @@ newlocale(int mask, const char *name, lo
        if (src == NULL)
                src = _current_locale();
        memcpy(dst, src, sizeof(*src));
-       strlcpy(&head[0], name, sizeof(head));
+       if (strlcpy(&head[0], name, sizeof(head)) >= sizeof(head)) {
+               free(dst);
+               return (locale_t)NULL;
+       }
        tokens[0] = (const char *)&head[0];
        tail = strchr(tokens[0], '/');
        if (tail == NULL) {
@@ -77,6 +80,7 @@ newlocale(int mask, const char *name, lo
                }
                if (howmany-- > 0) {
                        for (i = 1; i < howmany; ++i) {
+                               *tail++ = '\0';
                                tokens[i] = (const char *)tail;
                                tail = strchr(tokens[i], '/');
                                if (tail == NULL) {
@@ -84,6 +88,7 @@ newlocale(int mask, const char *name, lo
                                        return NULL;
                                }
                        }
+                       *tail++ = '\0';
                        tokens[howmany] = tail;
                        tail = strchr(tokens[howmany], '/');
                        if (tail != NULL) {