[src/trunk]: src/usr.sbin/npf PR kern/55654:

[kardel <kardel%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/869209be177c
branches:  trunk
changeset: 373483:869209be177c
user:      kardel <kardel%NetBSD.org@localhost>
date:      Sun Feb 12 13:21:28 2023 +0000

description:
PR kern/55654:
Switch default for parameter npf ip4.reassembly to 1.
This makes the NPF default configuration comply with host
requirements for IPv4.

diffstat:

 sys/net/npf/npf_params.c  |  4 ++--
 usr.sbin/npf/npf-params.7 |  8 ++++----
 2 files changed, 6 insertions(+), 6 deletions(-)

diffs (45 lines):

diff -r ebc47c31bfb0 -r 869209be177c sys/net/npf/npf_params.c
--- a/sys/net/npf/npf_params.c  Sun Feb 12 10:18:23 2023 +0000
+++ b/sys/net/npf/npf_params.c  Sun Feb 12 13:21:28 2023 +0000
@@ -26,7 +26,7 @@
 
 #ifdef _KERNEL
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: npf_params.c,v 1.5 2022/04/28 17:28:15 martin Exp $");
+__KERNEL_RCSID(0, "$NetBSD: npf_params.c,v 1.6 2023/02/12 13:21:28 kardel Exp $");
 
 #include <sys/param.h>
 #include <sys/types.h>
@@ -56,7 +56,7 @@
                {
                        "ip4.reassembly",
                        &npf->ip4_reassembly,
-                       .default_val = 0, // false
+                       .default_val = 1, // true - host requirements
                        .min = 0, .max = 1
                },
                {
diff -r ebc47c31bfb0 -r 869209be177c usr.sbin/npf/npf-params.7
--- a/usr.sbin/npf/npf-params.7 Sun Feb 12 10:18:23 2023 +0000
+++ b/usr.sbin/npf/npf-params.7 Sun Feb 12 13:21:28 2023 +0000
@@ -1,4 +1,4 @@
-.\" $NetBSD: npf-params.7,v 1.8 2020/12/17 05:33:06 taca Exp $
+.\" $NetBSD: npf-params.7,v 1.9 2023/02/12 13:21:28 kardel Exp $
 .\"
 .\" Copyright (c) 2019 Mindaugas Rasiukevicius <rmind at netbsd org>
 .\" All rights reserved.
@@ -60,11 +60,11 @@
 .It Li ip4.reassembly
 Perform IPv4 reassembly before inspecting the packet.
 Fragmentation is considered very harmful, so most networks are expected
-to prevent it; therefore, reassembly is disabled by default.
+to prevent it; reassembly is enabled by default.
 However, while the packet should generally be reassembled at the receiver,
-reassembly by the packet filter might be necessary in order to perform state
+reassembly by the packet filter may be necessary in order to perform state
 tracking.
-Default: 0.
+Default: 1.
 .It Li ip6.reassembly
 Perform IPv6 reassembly before inspecting the packet.
 Discouraged in general but not prohibited by RFC 8200.