[src/trunk]: src/sys/external/bsd/acpica/dist/executer exsystem.c: revert ACP...

[gutteridge <gutteridge%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/b5675158c6d6
branches:  trunk
changeset: 372548:b5675158c6d6
user:      gutteridge <gutteridge%NetBSD.org@localhost>
date:      Wed Dec 07 05:38:27 2022 +0000

description:
exsystem.c: revert ACPI warning about sleep values >10ms

acpica 20220331 introduced the following change:

For the ASL Sleep() operator, issue a warning if the sleep value is
greater than 10 Milliseconds. Quick boottime is important, so warn about
sleeps greater than 10 ms. Distribution Linux kernels reach initrd in 350
ms, so excessive delays should be called out. 10 ms is chosen randomly,
but three of such delays would already make up ten percent of the
boottime.

This can generate many console messages like:
[    26.055036] ACPI Warning: Firmware issue: Excessive sleep time (0x0000000000000064 ms > 10 ms) in ACPI Control Method (20220331/exsystem-239)
(60 of them in the latest boot on one older Ivy Bridge laptop.)

This has been reverted upstream and is not present in the next release.
https://github.com/acpica/acpica/commit/df896f452f945d498736c5775d4ee6629df31786
(Also previously reverted in FreeBSD and Linux.)

diffstat:

 sys/external/bsd/acpica/dist/executer/exsystem.c |  12 ------------
 1 files changed, 0 insertions(+), 12 deletions(-)

diffs (22 lines):

diff -r 925dcf68e257 -r b5675158c6d6 sys/external/bsd/acpica/dist/executer/exsystem.c
--- a/sys/external/bsd/acpica/dist/executer/exsystem.c  Tue Dec 06 15:51:16 2022 +0000
+++ b/sys/external/bsd/acpica/dist/executer/exsystem.c  Wed Dec 07 05:38:27 2022 +0000
@@ -231,18 +231,6 @@
     AcpiExExitInterpreter ();
 
     /*
-     * Warn users about excessive sleep times, so ASL code can be improved to
-     * use polling or similar techniques.
-     */
-    if (HowLongMs > 10)
-    {
-        ACPI_WARNING ((AE_INFO,
-            "Firmware issue: Excessive sleep time (0x%8.8X%8.8X ms > 10 ms)"
-            " in ACPI Control Method",
-            ACPI_FORMAT_UINT64 (HowLongMs)));
-    }
-
-    /*
      * For compatibility with other ACPI implementations and to prevent
      * accidental deep sleeps, limit the sleep time to something reasonable.
      */