Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src-draft/trunk]: src/sys/dev/pci Avoid double free of mbufs/nodes-



details:   https://anonhg.NetBSD.org/src-all/rev/a278d9fe79d4
branches:  trunk
changeset: 370994:a278d9fe79d4
user:      Martin Husemann <martin%NetBSD.org@localhost>
date:      Thu Dec 10 15:30:19 2020 +0100

description:
Avoid double free of mbufs/nodes-

Do not free nodes and mbufs that we just have handed over to the
hardware for further processing, they will be freed on completition.

diffstat:

 sys/dev/pci/if_rtwn.c |  3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diffs (20 lines):

diff -r 9e56cca2b5f1 -r a278d9fe79d4 sys/dev/pci/if_rtwn.c
--- a/sys/dev/pci/if_rtwn.c     Wed Oct 28 21:34:29 2020 +1100
+++ b/sys/dev/pci/if_rtwn.c     Thu Dec 10 15:30:19 2020 +0100
@@ -65,7 +65,6 @@
 #include <dev/ic/rtwn_data.h>
 #include <dev/pci/if_rtwnreg.h>
 
-#define RTWN_DEBUG 1
 #ifdef RTWN_DEBUG
 #define DPRINTF(x)     do { if (rtwn_debug) printf x; } while (0)
 #define DPRINTFN(n, x) do { if (rtwn_debug >= (n)) printf x; } while (0)
@@ -2206,8 +2205,6 @@
                                if_statinc(vap->iv_ifp, if_oerrors);
                        continue;
                }
-               m_freem(m);
-               ieee80211_free_node(ni);
                sc->sc_tx_timer = 5;
                callout_schedule(&sc->sc_watchdog_to, hz);
        }



Home | Main Index | Thread Index | Old Index