[src/trunk]: src/sys/dev/usb uhid(4): Don't wake waiters on changing sc_open.

[riastradh <riastradh%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/1ff55419e237
branches:  trunk
changeset: 370683:1ff55419e237
user:      riastradh <riastradh%NetBSD.org@localhost>
date:      Sat Sep 24 11:06:41 2022 +0000

description:
uhid(4): Don't wake waiters on changing sc_open.

This is only a diagnostic measure, not part of semantics.

Can probably safely eliminate the diagnostic measure at this point
now.

diffstat:

 sys/dev/usb/uhid.c |  7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)

diffs (42 lines):

diff -r 111e12d50b10 -r 1ff55419e237 sys/dev/usb/uhid.c
--- a/sys/dev/usb/uhid.c        Sat Sep 24 11:06:03 2022 +0000
+++ b/sys/dev/usb/uhid.c        Sat Sep 24 11:06:41 2022 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: uhid.c,v 1.125 2022/03/31 17:43:50 christos Exp $      */
+/*     $NetBSD: uhid.c,v 1.126 2022/09/24 11:06:41 riastradh Exp $     */
 
 /*
  * Copyright (c) 1998, 2004, 2008, 2012 The NetBSD Foundation, Inc.
@@ -35,7 +35,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: uhid.c,v 1.125 2022/03/31 17:43:50 christos Exp $");
+__KERNEL_RCSID(0, "$NetBSD: uhid.c,v 1.126 2022/09/24 11:06:41 riastradh Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_compat_netbsd.h"
@@ -314,7 +314,6 @@
        /* We are open for business.  */
        mutex_enter(&sc->sc_lock);
        sc->sc_open = UHID_OPEN;
-       cv_broadcast(&sc->sc_cv);
        mutex_exit(&sc->sc_lock);
 
        return 0;
@@ -331,7 +330,6 @@
 fail0: mutex_enter(&sc->sc_lock);
        KASSERT(sc->sc_open == UHID_OPENING);
        sc->sc_open = UHID_CLOSED;
-       cv_broadcast(&sc->sc_cv);
        atomic_store_relaxed(&sc->sc_state, 0);
        mutex_exit(&sc->sc_lock);
        return error;
@@ -403,7 +401,6 @@
        sc->sc_open = UHID_CLOSED;
 out:   KASSERT(sc->sc_open == UHID_CLOSED);
        sc->sc_closing = false;
-       cv_broadcast(&sc->sc_cv);
        atomic_store_relaxed(&sc->sc_state, 0);
        mutex_exit(&sc->sc_lock);