Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/arch/newsmips/apbus snstart(): Replace "IF_DEQUEUE() -> ...



details:   https://anonhg.NetBSD.org/src/rev/a011b442025a
branches:  trunk
changeset: 369516:a011b442025a
user:      thorpej <thorpej%NetBSD.org@localhost>
date:      Sat Aug 20 18:42:03 2022 +0000

description:
snstart(): Replace "IF_DEQUEUE() -> IF_PREPEND() on failure" with
"IF_POLL() -> IF_DEQUEUE() on success".

diffstat:

 sys/arch/newsmips/apbus/if_sn.c |  12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diffs (44 lines):

diff -r 754c04e4c9b1 -r a011b442025a sys/arch/newsmips/apbus/if_sn.c
--- a/sys/arch/newsmips/apbus/if_sn.c   Sat Aug 20 18:40:35 2022 +0000
+++ b/sys/arch/newsmips/apbus/if_sn.c   Sat Aug 20 18:42:03 2022 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_sn.c,v 1.49 2020/02/05 13:08:19 martin Exp $        */
+/*     $NetBSD: if_sn.c,v 1.50 2022/08/20 18:42:03 thorpej Exp $       */
 
 /*
  * National Semiconductor  DP8393X SONIC Driver
@@ -16,7 +16,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_sn.c,v 1.49 2020/02/05 13:08:19 martin Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_sn.c,v 1.50 2022/08/20 18:42:03 thorpej Exp $");
 
 #include "opt_inet.h"
 
@@ -320,7 +320,7 @@
                return;
        }
 
-       IF_DEQUEUE(&ifp->if_snd, m);
+       IF_POLL(&ifp->if_snd, m);
        if (m == 0)
                return;
 
@@ -336,13 +336,13 @@
 
        /*
         * If there is nothing in the o/p queue, and there is room in
-        * the Tx ring, then send the packet directly.  Otherwise append
-        * it to the o/p queue.
+        * the Tx ring, then send the packet directly.  Otherwise it
+        * stays on the queue.
         */
        if ((sonicput(sc, m, mtd_next)) == 0) {
-               IF_PREPEND(&ifp->if_snd, m);
                return;
        }
+       IF_DEQUEUE(&ifp->if_snd, m);
 
        sc->mtd_prev = sc->mtd_free;
        sc->mtd_free = mtd_next;



Home | Main Index | Thread Index | Old Index